Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction's description is not stored in database. #94

Open
akoSalman opened this issue Jan 3, 2018 · 1 comment
Open

Transaction's description is not stored in database. #94

akoSalman opened this issue Jan 3, 2018 · 1 comment

Comments

@akoSalman
Copy link
Contributor

akoSalman commented Jan 3, 2018

First of all thank you for your nice package.
When user makes a payment request with some description, description is sent to bank's gateway, but not returned to the callback url, and not stored with transaction's detail on payment request also.
I think it's good to add a description field to gateway_transactions table and store the description on transaction initialization also.
In my case, i store description in a temporary table when transaction is initialized and append it to my customized transactions table on transaction's callback.
I can add it to the package and make a PR if you are agree with me.

@hpakdaman
Copy link
Contributor

hpakdaman commented Feb 26, 2018

Hello ,
Nice Idea . Go ahead and send PR to me, I'll accept it.
Please write a customize function in PortAbstract.php , this function is arbitrary to use.
The function's name could be ->setNote('') or ->setCustomNote('') .
Also make a migration for database changes please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants