Fixed duplicate migration generation issue by passing --no-migration fixes #40 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flag to make model command
|
Great addition! Thank you @vinnizworld . Merging it into the v2 branch now. Let me know if you're interested in helping out with other stuff in v2 - this repo is finally getting up-to-date, and the attention it deserves, after we've taken it for granted all these years 😄 Cheers! |
This was referenced Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 5's
artisan make:model ModelNamecommand creates a model as well as migration file for the given model, you need to specify--no-migrationflag in order to skip the automatic migration generation by laravel.Because this generator tool explicitly generates migration based on given schema, we don't need that extra migration file, so we can safely always pass
--no-migrationflag to skip generation of that extra file.Which ultimately fixes #40.