Fixing host resource and provider out-of-sync

[nightw]

From #173

The resources/host.rb file contains attributes for groups, templates and interfaces, but those are currently ignored in the providers/host.rb, since that file is only using the parameters[:groupNames], parameteres[:templates] and parameteres[:interfaces] attribute respectively for registering a host to the Zabbix server.

Fixing this issue while I tried to keep the backward compatibility to not brake the agent_registration recipe and other people's application cookbooks using this resource the old way. Could you please review it?

[nightw]

It fixes issue #173

[guilhem]

Why are you removing interfaces?
You are using it here

[nightw]

This was a sneak-in small fix for this line to being a duplicate in the resource file (for some time, I've not checked the git blame for this too much). The other, same line is preserved, see here

[guilhem]

Yeah. I like to see small fix like that! :)
That mean that some people read the code.

[guilhem]

Seems to be ok for me (modulo my inline comments)

[guilhem]

👍 for me if @nightw can guarantee us that TK is OK ;)

[nightw]

What does 'TK' mean? :)

[guilhem]

Oh sorry, it stand for Test Kitchen

[nightw]

Oh, my bad, I'm using Test Kitchen myself too, I just did not know the acronym. I've just tested it and it's OK (the opscode-centos-5.9 box is 404, the others were good). (btw this is not surprising, since the .kitchen.yml file only tests the default recipe, which only installs the Zabbix agent. I think the coverage should be increased somehow.)

Also Foodcritic does not tell any hints.

[nightw]

Since the TK is also OK, please merge this