Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xdebug 3 compatibility with PHP 7.3 and 7.4 #3206

Merged
merged 1 commit into from Oct 23, 2022

Conversation

DocLM
Copy link
Contributor

@DocLM DocLM commented Apr 29, 2022

Description

Add version check to Xdebug configuration to match the check used to install Xdebug 3.
Previously only PHP 8 use v3 but now also PHP 7.4 and 7.3 need configuration adjustments to work as expected.
I've also updated Xdebug version to match the latest version (3.1.4) available on PECL at the time of writing.
Since Xdebug 3 use port 9003 as default I've added a configuration variable to allow to specify Xdebug port for php-fpm and workspace container

Fixes #3099 and #3169 if used with default configuration (probably also fixes #3083)

Motivation and Context

Fixes issues caused by the migration to Xdebug 3 for PHP version 7.4 and 7.4.
Also add the ability to select a custom port instead of 9003 for Xdebug in workspace and php-fpm.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

  • I've read the Contribution Guide.
  • I've updated the documentation. (refer to this for how to do so).
  • I enjoyed my time contributing and making developer's life easier :)

@PaolaRuby
Copy link
Contributor

Probably also fixes #3230

@Skatox
Copy link

Skatox commented Sep 7, 2022

I would like this patch gets approved. I'm having this issue.

@wangtufly
Copy link

I would like this patch gets approved. I'm having this issue. +1

- Allow to set custom Xdebug port
- Update Xdebug to v3.1.4
@DocLM
Copy link
Contributor Author

DocLM commented Oct 22, 2022

@bestlong what do you think about these changes?
A working debugger is one of the most important feature a developer should have.

@bestlong bestlong merged commit 2ff93b5 into laradock:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xdebug version to install in php-fpm according php version doesn't work in 7.4 xdebug 3.1 not work
5 participants