feat: rescue parameter of rescue function now accepts the Throwable (…

…#989)
larastan · Oct 29, 2021 · 08ef81b · 08ef81b
1 parent 695d005
commit 08ef81b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/stubs/Helpers.stub b/stubs/Helpers.stub
@@ -5,7 +5,7 @@
  * @template TDefault
  *
  * @param callable(): TValue $callback
- * @param TDefault|(callable(): TDefault) $rescue
+ * @param TDefault|(callable(\Throwable): TDefault) $rescue
  * @param bool $report
  * @return TValue|TDefault
  */

diff --git a/tests/Features/ReturnTypes/Helpers/RescueStub.php b/tests/Features/ReturnTypes/Helpers/RescueStub.php
@@ -6,6 +6,7 @@
 
 use Exception;
 use function PHPStan\Testing\assertType;
+use Throwable;
 
 class RescueStub
 {
@@ -50,7 +51,22 @@ public function testRescueWithClosureDefault(): void
         assertType('int|string', $rescued);
     }
 
-    public function testRetryWithoutReporting(): void
+    public function testRescueWithClosureDefaultThrowable(): void
+    {
+        $rescued = rescue(function () {
+            if (mt_rand(0, 1)) {
+                throw new Exception();
+            }
+
+            return 'ok';
+        }, function (Throwable $e) {
+            return 0;
+        });
+
+        assertType('int|string', $rescued);
+    }
+
+    public function testRescueWithoutReporting(): void
     {
         $rescued = rescue(function () {
             if (mt_rand(0, 1)) {