fix: dynamic wheres can have a mixed parameter

larastan · Mar 2, 2020 · 304edc0 · 304edc0
1 parent 56b0b2c
commit 304edc0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/src/Methods/BuilderHelper.php b/src/Methods/BuilderHelper.php
@@ -14,7 +14,9 @@
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Reflection\MissingMethodFromReflectionException;
 use PHPStan\Reflection\ParametersAcceptorSelector;
+use PHPStan\Reflection\Php\DummyParameter;
 use PHPStan\ShouldNotHappenException;
+use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
@@ -53,11 +55,17 @@ public function dynamicWhere(
         /** @var FunctionVariantWithPhpDocs $originalDynamicWhereVariant */
         $originalDynamicWhereVariant = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
 
+        /** @var \PHPStan\Reflection\ParameterReflectionWithPhpDocs $originalParameter */
+        $originalParameter = $originalDynamicWhereVariant->getParameters()[1];
+
+        $actualParameter = new DummyParameter($originalParameter->getName(), new MixedType(), $originalParameter->isOptional(), $originalParameter->passedByReference(), $originalParameter->isVariadic(), $originalParameter->getDefaultValue());
+
         return new EloquentBuilderMethodReflection(
             $methodName,
             $classReflection,
-            [$originalDynamicWhereVariant->getParameters()[1]],
-            $returnObject
+            [$actualParameter],
+            $returnObject,
+            true
         );
     }
 

diff --git a/tests/Features/Methods/Builder.php b/tests/Features/Methods/Builder.php
@@ -13,4 +13,19 @@ public function testGroupBy(): EloquentBuilder
     {
         return User::query()->groupBy('foo', 'bar');
     }
+
+    public function testDynamicWhereAsString(): ?User
+    {
+        return (new User())->whereFoo('bar')->first();
+    }
+
+    public function testDynamicWhereMultiple(): ?User
+    {
+        return User::whereIdAndEmail(1, 'foo@example.com')->first();
+    }
+
+    public function testDynamicWhereAsInt(): ?User
+    {
+        return (new User())->whereFoo(1)->first();
+    }
 }