Merge pull request #666 from nunomaduro/patch-1

fix: use reflection to get table name in ModelPropertyExtension

src/Properties/ModelPropertyExtension.php

@@ -13,6 +13,7 @@
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\PropertiesClassReflectionExtension;
 use PHPStan\Reflection\PropertyReflection;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\IntegerType;
 use RecursiveDirectoryIterator;
 use RecursiveIteratorIterator;
@@ -73,9 +74,17 @@ public function hasProperty(ClassReflection $classReflection, string $propertyNa
         }
 
         $modelName = $classReflection->getNativeReflection()->getName();
-        /** @var Model $modelInstance */
-        $modelInstance = new $modelName;
-        $tableName = $modelInstance->getTable();
+
+        try {
+            $reflect = new \ReflectionClass($modelName);
+
+            /** @var Model $modelInstance */
+            $modelInstance = $reflect->newInstanceWithoutConstructor();
+
+            $tableName = $modelInstance->getTable();
+        } catch (\ReflectionException $e) {
+            return false;
+        }
 
         if (! array_key_exists($tableName, $this->tables)) {
             return false;
@@ -105,9 +114,18 @@ public function getProperty(
     ): PropertyReflection {
         $modelName = $classReflection->getNativeReflection()->getName();
 
-        /** @var Model $modelInstance */
-        $modelInstance = new $modelName;
-        $tableName = $modelInstance->getTable();
+        try {
+            $reflect = new \ReflectionClass($modelName);
+
+            /** @var Model $modelInstance */
+            $modelInstance = $reflect->newInstanceWithoutConstructor();
+
+            $tableName = $modelInstance->getTable();
+        } catch (\ReflectionException $e) {
+            // `hasProperty` should return false if there was a reflection exception.
+            // so this should never happen
+            throw new ShouldNotHappenException();
+        }
 
         if (
             (! array_key_exists($tableName, $this->tables)

tests/Application/app/GuardedModel.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App;
+
+use Illuminate\Database\Eloquent\Model;
+
+class GuardedModel extends Model
+{
+    protected $guarded = ['text'];
+
+    /**
+     * @param array<string, mixed> $attributes
+     */
+    public function __construct(array $attributes = [])
+    {
+        dd(debug_backtrace()[0]);
+        $attributes['name'] = $attributes['name'] ?? 'foo';
+
+        parent::__construct($attributes);
+    }
+}

tests/Application/database/migrations/2020_09_25_190200_create_guarded_models_table.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreateGuardedModelsTable extends Migration
+{
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+        Schema::create('guarded_models', static function (Blueprint $table) {
+            $table->id();
+            $table->string('name');
+            $table->string('text');
+            $table->timestamps();
+        });
+    }
+}

tests/Features/Properties/ModelPropertyExtension.php

@@ -6,6 +6,7 @@
 
 use App\Account;
 use App\Group;
+use App\GuardedModel;
 use App\Role;
 use App\User;
 use Carbon\Carbon as BaseCarbon;
@@ -110,4 +111,9 @@ public function testWriteIdPropertyWhenMigrationsCouldntBeRead(): bool
 
         return $group->save();
     }
+
+    public function testModelWithGuardedProperties(GuardedModel $guardedModel): string
+    {
+        return $guardedModel->name;
+    }
 }