feat: add support for Storage::drive besides Storage::disk (#1241)

larastan · May 23, 2022 · c1f8bc7 · c1f8bc7
1 parent 99861c5
commit c1f8bc7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Improvements
 * feat: Added conditional return types
 
+### Improvements
+* feat: add Storage::drive() support by @PrinsFrank in https://github.com/nunomaduro/larastan/pull/1241
+
 ### Fixes
 
 * fix: Change QueryBuilder::newQuery() @return from `$this` to `static`

diff --git a/src/ReturnTypes/StorageDynamicStaticMethodReturnTypeExtension.php b/src/ReturnTypes/StorageDynamicStaticMethodReturnTypeExtension.php
@@ -25,7 +25,7 @@ public function getClass(): string
 
     public function isStaticMethodSupported(MethodReflection $methodReflection): bool
     {
-        return $methodReflection->getName() === 'disk';
+        return $methodReflection->getName() === 'disk' || $methodReflection->getName() === 'drive';
     }
 
     public function getTypeFromStaticMethodCall(

diff --git a/tests/Features/Methods/StorageFacade.php b/tests/Features/Methods/StorageFacade.php
@@ -14,11 +14,21 @@ public function testDisk(): Filesystem
         return Storage::disk();
     }
 
+    public function testDrive(): Filesystem
+    {
+        return Storage::drive();
+    }
+
     public function testDiskGetDriver(): bool
     {
         return Storage::disk()->deleteDirectory('foo');
     }
 
+    public function testDriveGetDriver(): bool
+    {
+        return Storage::drive()->deleteDirectory('foo');
+    }
+
     /** @return string|false */
     public function testPutFile()
     {