Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct method reflection for magic with* calls on RedirectResponse #1016

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Nov 7, 2021

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Fixes #586

Changes

This PR implements correct method reflection for magic with* on RedirectResponse class

Breaking changes

@canvural canvural changed the title fix: correct method reflection for magic with* calls on RedirectResponse fix: correct method reflection for magic with* calls on RedirectResponse Nov 7, 2021
@canvural canvural merged commit 6a4b861 into master Nov 8, 2021
@canvural canvural deleted the redirect-response-with branch November 8, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedirectResponse::with() expects array|string, true given
1 participant