Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the tap helper should not enforce any return type for the callback #1031

Merged
merged 1 commit into from
Nov 15, 2021
Merged

fix: the tap helper should not enforce any return type for the callback #1031

merged 1 commit into from
Nov 15, 2021

Conversation

tpetry
Copy link
Contributor

@tpetry tpetry commented Nov 15, 2021

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #1030

Changes

The tap helper declared a void return type for the closure. But as the return value is never used, there should not be a restricting type.

@szepeviktor szepeviktor merged commit 19098c7 into larastan:master Nov 15, 2021
@tpetry tpetry deleted the tap-helper branch November 15, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor approved these changes

@nunomaduro nunomaduro nunomaduro approved these changes

@canvural canvural Awaiting requested review from canvural

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tap helper closure enforces void return type
3 participants
@tpetry @szepeviktor @nunomaduro