-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect ancestor property tags in model extensions #1037
fix: respect ancestor property tags in model extensions #1037
Conversation
Hello Benedikt! |
I think it is great that Larastan can recognize magic properties, but there are still situations that require an escape hatch:
Larastan seems to recognize the necessity of this, given there is already an early return if a property annotation exists. I don't see why this logic should not extend to annotations from ancestors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I had the same thing in mind actually.
Just left one remark. And after that I will refactor the test cases for this.
I would still welcome these features in Larastan. |
Thank you! |
Documented user facing changesChanges
Ensure the model extensions considers PHPDoc
@property
tags from ancestors, not just the model class itself.Breaking changes
None.