Fix SchemaAggregation when renaming tables through non-static method call #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Nils! 👋 |
|
Thank you! |
|
Happy to contribute, love how the project is tested. Keep up the great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In Laravel migrations we can rename a table by getting a reference to the table through Schema::table and renaming the table via the rename method.
Larastan analyzes those cases incorrectly, but rather treats them the same as a "renameColumn" call, resulting in "trying to access undefined property x" errors on models whose tables were renamed through that method.
This PR aims at changing that.
The method does not seem to be well documented but when you already have migrations using the method, it's hard to change them afterwards.
Breaking changes
I'm not aware of any.