fix: incorrect return type by route on Request class
#1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvural
requested changes
Feb 7, 2022
There was a problem hiding this comment.
Hi,
Thank you!
Overall it looks fine. But couple of things:
- Please target the
masterbranch.1.xbranch will no longer receive new features. Only critical bug fixes. - Changelog does not look correct. But I guess when you target the
masterbranch, you can just add your changes.
Conflicts: CHANGELOG.md README.md tests/laravel-test.sh
|
@canvural Rebase to |
canvural
approved these changes
Feb 8, 2022
canvural
changed the title
route on Request classroute on Request class
|
Thank you! |
|
@fragkp Very well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1112
Changes
Returns now the correct return type by given parameters.
Breaking changes
No breaking changes.
Note
First time using the extension mechanism. Please review carefully, thx ❤️