Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace composer with copy of ClassMapGenerator #1119

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

canvural
Copy link
Collaborator

@canvural canvural commented Feb 9, 2022

This PR fixes #1117 by removing composer/composer dependency with copying ClassMapGenerator into our code.

Inspired from barryvdh/laravel-ide-helper@3b03e40 and composer/composer#10527

@canvural canvural merged commit 46607e4 into master Feb 9, 2022
@canvural canvural deleted the replace-class-map-generator branch February 9, 2022 15:24
@barryvdh
Copy link

barryvdh commented Feb 9, 2022

Ahhh you broke the copy chain from barryvdh/laravel-ide-helper@3b03e40#diff-40b3e93b226d77d52c8e540b46e98eda6d0f9a7d1f25b7d5770dae36ef238aa9R14

This file is copied from the Symfony package to composer/composer and then copied to barryvdh/laravel-ide-helper and finally here.

😘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symfony/console and composer/composer dependancy conflict on Larastan 2.0.0
2 participants