Date type extension #1142
Merged
Date type extension #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastien-phi
force-pushed
the
date_extension
branch
from
2000cbf
to
b2f44fa
Compare
bastien-phi
force-pushed
the
date_extension
branch
from
5d07dfe
to
40a6c1d
Compare
|
Thank you. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #421. The code is taken from #438 and some tests were added.
I've been using initial implementation in projects for a long time and as I found a way to test it, I think it now deserves to be in this package.
Changes
Now, when using
Date::use(CarbonImmutable::class), the helpersnow(),today()and models' timestamps are determined to beCarbonImmutable.It also adds an extension to determine return types of
Illuminate\Support\Facade\Datemethods when a custom date Factory is used (for exemple,Date::createFromStringreturnsCarbonImmutable)Breaking changes
I don't think so