Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PHPStan version and stubs #1144

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

canvural
Copy link
Collaborator

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Fixes #926

Changes
This PR updates minimum PHPStan version because it contains fixes we need and updates the Builder stubs to fix #926.

Breaking changes

@canvural canvural merged commit fbdf481 into master Feb 28, 2022
@canvural canvural deleted the update-builder-stubs branch February 28, 2022 14:25
@fragkp
Copy link
Contributor

fragkp commented Mar 10, 2022

Hey @canvural,

this change don't work with Custom Builders ->where(function (CustomEloquentBuilder $query)...). Can u give me hint on how to allow Custom Builders as type, so I can submit a PR?

@canvural
Copy link
Collaborator Author

@fragkp Can you open a new issue with the error you are getting?

@fragkp
Copy link
Contributor

fragkp commented Mar 14, 2022

@canvural Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-generic type when type hinting builder on Eloquent where* methods
2 participants