Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix: change QueryBuilder::newQuery() @return from $this to static #1221

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix: fix: change QueryBuilder::newQuery() @return from $this to static #1221

merged 1 commit into from
Apr 28, 2022

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Apr 28, 2022

newQuery(), as the name implies, creates a new instance, so the return
type should not be $this, but static instead.

@dotdash
fix: Change QueryBuilder::newQuery() @return from $this to static
3cf06de 
newQuery(), as the name implies, creates a new instance, so the return
type should not be `$this`, but `static` instead.
@szepeviktor
Copy link
Collaborator

https://github.com/laravel/framework/blob/v9.9.0/src/Illuminate/Database/Query/Builder.php#L3437

@canvural canvural changed the title fix: Change QueryBuilder::newQuery() @return from $this to static fix: fix: change QueryBuilder::newQuery() @return from $this to static Apr 28, 2022
@canvural canvural merged commit 3ff9b57 into larastan:master Apr 28, 2022
@canvural
Copy link
Collaborator

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotdash @szepeviktor @canvural