Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Model property types #1234

Merged
merged 2 commits into from
May 23, 2022
Merged

Fix Model property types #1234

merged 2 commits into from
May 23, 2022

Conversation

szepeviktor
Copy link
Collaborator

@szepeviktor szepeviktor commented May 16, 2022 •
edited

These are simple lists,

[
  1 => 'apple',
  3 => 'pear',
]

is invalid!

@szepeviktor szepeviktor requested a review from canvural May 16, 2022 07:33
@canvural
Copy link
Collaborator

Hi,

This change would allow string keys also. But we can do list<string> here. Can you change it to list here?

@szepeviktor
Copy link
Collaborator Author

Can you change it to list here?

Done.

@canvural canvural merged commit 99861c5 into master May 23, 2022
@canvural
Copy link
Collaborator

Thank you.

@canvural canvural deleted the szepeviktor-patch-1 branch May 23, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canvural canvural Awaiting requested review from canvural

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szepeviktor @canvural