Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better return types for App::environment #1303

Merged
merged 4 commits into from
Aug 24, 2022
Merged

fix: better return types for App::environment #1303

merged 4 commits into from
Aug 24, 2022

Conversation

crissi
Copy link
Contributor

@crissi crissi commented Jul 1, 2022 •
edited by szepeviktor

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Resolves #1229

Changes

fixes return types for App::environment()

@crissi crissi force-pushed the app_environment_return_type_extension branch 2 times, most recently from dbfeba7 to 883372b Compare July 1, 2022 20:05
@szepeviktor
Copy link
Collaborator

Very well done, Christian! 💎

canvural
canvural requested changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@canvural canvural left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small remark, other than it's good!

tests/Features/ReturnTypes/AppAccessTest.php Outdated Show resolved Hide resolved
@crissi crissi marked this pull request as draft July 4, 2022 13:52
@crissi crissi force-pushed the app_environment_return_type_extension branch 3 times, most recently from f7a1cc6 to 6f37b5e Compare July 4, 2022 14:01
@crissi crissi marked this pull request as ready for review July 4, 2022 14:03
@canvural canvural force-pushed the app_environment_return_type_extension branch from d539746 to 4a3c701 Compare August 24, 2022 11:39
@canvural canvural changed the title fix return types App::environment fix: better return types for App::environment Aug 24, 2022
@canvural canvural merged commit 8b2112e into larastan:master Aug 24, 2022
@canvural
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canvural canvural canvural requested changes

@szepeviktor szepeviktor szepeviktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type helper for app()->environment()
3 participants
@crissi @szepeviktor @canvural