Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fromSub from stubs #1340

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

crissi
Copy link
Contributor

@crissi crissi commented Aug 25, 2022

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

removed fromSub from queryBuilder stub. Laravels phpdocs are more correct.

Right now fromSub will fail on an Eloquent Builder

@crissi crissi changed the title fix fromSub fix fromSub phpdocs Aug 25, 2022
@canvural canvural changed the title fix fromSub phpdocs fix: remove fromSub from stubs Aug 25, 2022
@canvural canvural merged commit 90236bc into larastan:master Aug 25, 2022
@canvural
Copy link
Collaborator

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants