Expand docblock of JoinSub to allow other models #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of this docblock used the template `TModelClass`.
However, this template was already in use at the class level,
effectively limiting the argument to `joinSub` to be a QueryBuilder of
the same type.
The test proved that this was allowed:
```
User::query()->joinSub(
User::query()->whereIn('id', [1, 2, 3]),
'users',
'users.id',
'users.id'
);
```
However, in the wild, I noticed that
`User::query()->joinSub(Post::query(), ...)` was _not_ allowed.
This change fixes that, simply by renaming the template in the `joinSub`
docblock.
|
Hi! |
|
Oh! So you want to free |
|
I'd merge it after having a quick line in the changelog. |
|
Sure thing! Do you want me to add a new section in the Changelog for |
|
In the |
|
Done! |
|
I like your dashes. |
|
Thank you! |
|
Oops. 😅 Glad you like them, that was Prettier auto-formatting the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on #1212.
Changes
The previous version of this docblock used the template
TModelClass.However, this template was already in use at the class level, effectively limiting the argument to
joinSubto be a QueryBuilder of the same type.The test proved that this was allowed:
However, in the wild, I noticed that
User::query()->joinSub(Post::query(), ...)was not allowed.This change fixes that, simply by renaming the template in the
joinSubdocblock.Breaking changes
None.