feat: detect usage of env() function outside of config folder #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
env
branch
3 times, most recently
from
99e48fd
to
1be6b05
Compare
|
Looks like tests are currently failing on |
|
Yes, the scheduled workflow also fails |
|
Hi, I think we can use Also I do not remember exactly now, but we might need to check that the function is actually coming from Laravel. Or at least that the function is in global namespace and not in Lastly, I'd prefer that it is disabled by default. |
|
Done |
canvural
approved these changes
Feb 8, 2024
szepeviktor
requested changes
Feb 8, 2024
|
What's useConfigPath? |
|
A method called in this PR: tests/Rules/NoEnvCallsOutsideOfConfigRuleTest.php |
mad-briller
reviewed
Feb 8, 2024
|
@szepeviktor should be fixed now, thanks for catching! |
szepeviktor
approved these changes
Feb 8, 2024
calebdw
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1695.
Changes
Hello!
This PR adds a rule to report any
envcalls outside the config directory. Currently it just checks for aconfigdirectory in the file name where the call is located. A more robust solution might be to use the container to grab the configured config path? However this is more complicated and I wasn't sure how exactly to do such a thing.Thanks!