-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not respecting return type of overridden Request::user() method. #1861
base: 2.x
Are you sure you want to change the base?
Conversation
You beat me to this! |
6a00d74
to
dbeaf43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Just left a one comment. Also the branch has merge conflicts now. That's why it is a good idea to put any test case in GeneralTypeTest
to at the end of the file. The order of the tests do not matter at all 😊
I get that order does not matter (other than for aesthetics), but you would still have merge conflicts if two separate PRs placed files in the same spot at the end of the file. |
4e9e12b
to
e131dcd
Compare
i'll get to this proper when i have some time after work |
Whats the status on this @mad-briller @calebdw @canvural |
This PR needs to be fixed. |
closes #1718
Changes
Change RequestUserExtension to use the specific type of an overridden
Request::user()
method