Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support SoftDeletes methods on relations #692

Merged
merged 6 commits into from
Oct 21, 2020
Merged

feat: support SoftDeletes methods on relations #692

merged 6 commits into from
Oct 21, 2020

Commits on Oct 20, 2020

  1. Add failing cases for SoftDeletes methods on relations

    @jdrieghe
    jdrieghe committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    d4ff5a5 View commit details
    Browse the repository at this point in the history

  2. Return DummyMethodReflection when the related model has the SoftDelet… 

    …es trait and the methodName is one of the SoftDeletes methods (withTrashed, withoutTrashed or onlyTrashed)
    @jdrieghe
    jdrieghe committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    18f57cd View commit details
    Browse the repository at this point in the history

  3. Add changelog entry for SoftDeletes methods on relations

    @jdrieghe
    jdrieghe committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    3e40576 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Return correct MethodReflection 

    We had to pull the logic out of the BuilderHelper and move it back in the RelationForwardsCallsExtension though.
    @jdrieghe
    jdrieghe committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    2d2bf8d View commit details
    Browse the repository at this point in the history

  2. Overwrite returnMethodReflection so that we still have the fallback e… 

    …xception.

We already return it later.
    @jdrieghe
    jdrieghe committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    b1e3721 View commit details
    Browse the repository at this point in the history

  3. This will always evaluate to false

    @jdrieghe
    jdrieghe committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    9fa0c93 View commit details
    Browse the repository at this point in the history