-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added omittable steps #44
Conversation
I took a quick glance at the changes and I think I agree with the overall design. I think I'll have a closer look at this in the next few days |
Unsure if caching would work in this case, as the point of |
I meant caching for the current request. For instance, both the I think |
Yep I get that, okay so out of sheer laziness I've used the spatie/once package for this purpose as it does a pretty good job at this with little code change. It's reduced the calls to |
This feature would be really nice indeed. |
I鈥檒l look at this once I鈥檓 back from vacation |
I've made couple of small changes to the PR. Most notably, I implemented the memoization of the available steps myself as I would rather not pull in a whole other dependency just for that. I also added a few extra tests to for the wizard and wizard repository. Other than that, looks good to me. Thanks for the contribution! |
Issue reference: #43
Please let me know if there's anything I can change here, I've tried to implement this in the most elegant way without having to modify a bunch of logic. I needed this for a personal project, and it works fine as is (afaik), but if there's a better way of doing this without rewriting the entire wizard logic let me know 馃槀