-
Notifications
You must be signed in to change notification settings - Fork 277
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request : Tailwindcss theme #215
Comments
That's great. Let's focus on merging the RTL first and then we'll move on with tailwind. Thanks! |
ok that's great thanks. |
@YacoubBelaoura If you have the time I guess it would be great if you could start working on this. |
ok, i will start working on it ASAP.
and there may be a need 2 refactor, to set the renderless components as separate packages. |
@YacoubBelaoura we should use the existing ui packages. Each package that is framework dependent has a bulma folder. The reason for this is that we can add tailwind/bootstrap/etc folders in the future. The idea is to reuse the existing renderless components. In fact, this is the main reason for the whole FE rewrite. |
so all themes will be packed in one package. |
The only change should be this line, because the whole (local) app should be written in the same CSS framework https://github.com/laravel-enso/enso/blob/master/resources/js/enso.js#L5 |
yes that's what i was talking about but there will be other compiled files that are not required.
require('dotenv').config();
...
const App = () => import('@enso-ui/ui/${process.env.THEME}';
...
and with that the user only change |
Definitely +1 on adding it the flag in |
@aocneanu . i have a question. regarding future upgrades and if there will be themes for other framework.
Edit: i have defined the same bulma classes with tailwind for this theme using |
Yeah, a busy period on my part too. I guess there might be other css frameworks supported in the future, why not. We can add a cli config where we can define the theme used for generating the files. For forms & tables we should use separate template files built around the renderless ones for tailwind instead of reusing the bulma templates with mocked tailwind classes. Ugrading the framework pages could be as easy as doing a search&replace for What do you think? |
@aocneanu any movement on this? |
Is this still being worked on? |
This is a feature request.
Prerequisites
(enso is made of many specialized packages: https://github.com/laravel-enso)
Description
tailwindcss theme
a clone of the current bulma theme using tailwind
this theme is using TailwindCss V1.0.0-beta4, so it will be ready for the final verstion
with this configurations, only to keep the look
this is only a mockup using Vue and tailwindcss to divide it for each enso component, so it will be easy to add it.
if there is an other idea for a different theme, i can change it.
if its ok, i can start merging it with enso and make a PR.
ps: there is no 🐛 #125 (comment)
The text was updated successfully, but these errors were encountered: