Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostCSS directly and include Tailwind UI #107

Merged

Conversation

avvertix
Copy link
Contributor

Hey, thanks for creating the preset. I'd like to propose some changes in how Tailwind is referenced.

Following Adam's Tailwind CSS Best Practice Patterns I found quite interesting the use of postcss-import and postcss-nested. I think they might be useful as a default. Doing so I removed laravel-mix-tailwind and added the plugins directly to the Laravel Mix postCss method call.

I also included tailwindcss/ui as a default instead of tailwindcss/custom-forms to let everyone use the new defaults they introduced.

Let me know if these changes make sense for the preset.

@michaeldyrynda michaeldyrynda changed the base branch from master to main August 9, 2020 11:59
@michaeldyrynda michaeldyrynda merged commit bb13770 into laravel-frontend-presets:main Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants