Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome.blade.php #127

Merged
merged 1 commit into from
May 9, 2023

Conversation

morpheus7CS
Copy link
Contributor

Hey to all,

currently, when the TALL preset is applied, and the user registers and logs into the application, the Home link on the welcome.blade.php view points to /home, which results in a 404.

I have updated the link to point to route('home') instead of the current url('/home') to fix this.

Kind regards,
g

@danharrin danharrin added the bug Something isn't working label May 9, 2023
@danharrin danharrin merged commit f571c49 into laravel-frontend-presets:master May 9, 2023
1 check passed
@danharrin
Copy link
Member

Thanks

@Supernova3339
Copy link

Sorry to put this to concern, but wouldn't RouteServiceProvider::home make more sense?

@morpheus7CS
Copy link
Contributor Author

morpheus7CS commented May 13, 2023

@Supernova3339 hey,

it probably would, if the functionality would have been the same as in Breeze, but since this preset doesn't ship with a dashboard.blade.php view that is present there, I just wanted to avoid 404s on a starter project as it might confuse the beginners who are merely starting out.

I think most people will override the welcome.blade.php view entirely shortly after installation, so this change made sense to me.

Kind regards,
g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants