Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change path and routes #132

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

bhargavraviya
Copy link
Contributor

@bhargavraviya bhargavraviya commented Jul 30, 2023

  • wrong file name stubs/default/postcss.config.cjs to postcss.config.js
  • Change of Laravel Livewire 3 path on the folder
  • change in routes of effect Livewire 3 (new)
  • change: add a logout button on the welcome.blade.php page

@danharrin
Copy link
Member

Hey, please fix the tests

@bhargavraviya
Copy link
Contributor Author

Hi @danharrin , there is no issue in your test case, but in your test case system, it shows an error.
https://github.com/laravel-frontend-presets/tall/actions/runs/5707042038/job/15464764322
please guide me on how to solve this.

@danharrin
Copy link
Member

I think you need to replace the strings like auth.login with the full class name Login::class for LW3 @bhargavraviya

@bhargavraviya
Copy link
Contributor Author

bhargavraviya commented Sep 2, 2023

auth
@danharrin
thank you for the replay I have changed the test case please check again if it is correct or not

@bhargavraviya
Copy link
Contributor Author

@danharrin
Any test case error is pending please guide me

@johnpbloch
Copy link

@bhargavraviya I think the workflow file (.github/workflows/tests.yml) needs to be updated to install v3 of livewire under the "Install Dependencies" step.

@bhargavraviya
Copy link
Contributor Author

bhargavraviya commented Oct 17, 2023

@bhargavraviya I think the workflow file (.github/workflows/tests.yml) needs to be updated to install v3 of livewire under the "Install Dependencies" step.

I have already livewire v3

@johnpbloch @danharrin

@johnpbloch
Copy link

Yes, but the test runner in GitHub actions doesn't.

  • Open .github/workflows/tests.yml in your editor.
  • Go to line 37
  • Change ^2.0 to ^3.0
  • Commit the change and push to this pull request branch

Tests will pass for this PR after that.

@bhargavraviya
Copy link
Contributor Author

I have changes Done

@johnpbloch please check and merged it

@johnpbloch
Copy link

@danharrin will have to take care of that.

@danharrin danharrin merged commit 915dbe1 into laravel-frontend-presets:master Oct 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants