Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2 #3

Closed
wants to merge 3 commits into from
Closed

Fixes #2 #3

wants to merge 3 commits into from

Conversation

yaviso
Copy link

@yaviso yaviso commented Apr 1, 2021

fix: ToOne forces data
fix: ToMany forces data

Fixes #2

@yaviso
fix: ToMany forces data
df65833 
fix: ToOne forces `data`

Fixes laravel-json-api#2
@yaviso
Update ResourceTest.php
7710aa1 
Changed the test
@yaviso
Copy link
Author

yaviso commented Apr 1, 2021

This is just a quick-and-dirty solution; it ignores the data test if links or meta is present.

@yaviso
Update ResourceTest.php
d70ed7c 
fix: force an empty object for `author`
@yaviso
Copy link
Author

yaviso commented Apr 1, 2021

(My apologies for the superfluous commits; I can't run the tests locally....)

@lindyhopchris
Copy link
Contributor

Closing this as I've answered the question in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToOne and ToMany should allow for having just one of data, links or meta fields
2 participants
@yaviso @lindyhopchris