Merge pull request #186 from laravel-enso/feature/usersPersonIdUnique

made the person_id unique for the users table

database/migrations/2017_01_01_111000_create_users_table.php

@@ -11,7 +11,7 @@ public function up()
         Schema::create('users', function (Blueprint $table) {
             $table->increments('id');
 
-            $table->integer('person_id')->unsigned()->index();
+            $table->integer('person_id')->unsigned()->unique();
 
             $table->integer('group_id')->unsigned()->index();
             $table->foreign('group_id')->references('id')->on('user_groups');

src/Http/Requests/ValidateUserRequest.php

@@ -15,7 +15,7 @@ public function authorize()
     public function rules()
     {
         return [
-            'person_id' => 'exists:people,id',
+            'person_id' => ['exists:people,id', $this->personUnique()],
             'group_id' => 'required|exists:user_groups,id',
             'role_id' => 'required|exists:roles,id',
             'email' => ['email', 'required', $this->emailUnique()],
@@ -37,4 +37,9 @@ protected function emailUnique()
     {
         return Rule::unique('people', 'email')->ignore($this->get('person_id'));
     }
+
+    protected function personUnique()
+    {
+        return Rule::unique('users', 'person_id')->ignore($this->get('person_id'));
+    }
 }

src/Upgrades/UsersPersonIdUnique.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace LaravelEnso\Core\Upgrades;
+
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+use LaravelEnso\Upgrade\Contracts\MigratesTable;
+use LaravelEnso\Upgrade\Helpers\Table;
+
+class UsersPersonIdUnique implements MigratesTable
+{
+    public function isMigrated(): bool
+    {
+        return Table::hasIndex('users', 'users_person_id_unique');
+    }
+
+    public function migrateTable(): void
+    {
+        Schema::table('users', fn (Blueprint $table) => $table
+            ->unique(['person_id']));
+    }
+}