Allow mix.extract() before mix.js() calls - closes #224

laravel-mix · Jan 30, 2017 · 89af7a6 · 89af7a6
1 parent 108f0a9
commit 89af7a6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/setup/webpack.config.js b/setup/webpack.config.js
@@ -306,7 +306,7 @@ if (Mix.copy) {
 }
 
 
-if (Mix.js.vendor) {
+if (Mix.extract) {
     module.exports.plugins.push(
         new webpack.optimize.CommonsChunkPlugin({
             names: [Mix.js.base + '/vendor', Mix.js.base + '/' + 'manifest'],

diff --git a/src/WebpackEntry.js b/src/WebpackEntry.js
@@ -98,12 +98,12 @@ class WebpackEntry {
      * Add any relevant vendor extractions to the entry.
      */
     addVendors() {
-        if (! this.mix.js.length || ! this.mix.js.vendor) return this;
+        if (! this.mix.js.length || ! this.mix.extract) return this;
 
         let vendorPath = (this.mix.js.base + '/vendor')
             .replace(this.mix.publicPath, '');
 
-        this.entry.add(vendorPath, this.mix.js.vendor);
+        this.entry.add(vendorPath, this.mix.extract);
 
         return this;
     }

diff --git a/src/index.js b/src/index.js
@@ -39,7 +39,7 @@ module.exports.js = (entry, output) => {
  * @param {array} libs
  */
 module.exports.extract = (libs) => {
-    Mix.js.vendor = libs;
+    Mix.extract = libs;
 
     return this;
 };