Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1024 Add globalVueStyles configuration option #1163

Merged
merged 1 commit into from Nov 6, 2017

Conversation

NoelDeMartin
Copy link
Contributor

Proposal to solve issue #1024

Having a global sass file with variables, mixins and functions is a common scenario, and right now the only option to use such file in .vue component files is importing it manually every time. From the vue-loader documentation we can see how they recommend solving this: Loading a global settings file

Having all this into account, I think it'd be sensible to have such an option in the mix manifest.

@pqt
Copy link

pqt commented Nov 3, 2017

Is there a way I can use this right now? It's an absolute gem of an addition.

@NoelDeMartin
Copy link
Contributor Author

@austinpaquette Until @JeffreyWay accepts or rejects the pull request, you could either use a fork of laravel-mix or implement this on the webpack config of your app.

Even thou I made this, I am still importing a sass file in each component file. It's a drag having to repeat that every time but it's maintainable at the moment. Depending on jeffrey's opinion on this I may start using a fork myself.

@pqt
Copy link

pqt commented Nov 6, 2017

Yeah, I'll wait this out for a few more days but if it's closed or becomes stagnant I'll do that. Super useful feature for sure!

@JeffreyWay
Copy link
Collaborator

Thanks! Sorry for taking so long to getting around to this PR.

@pqt
Copy link

pqt commented Nov 6, 2017

Thanks! Sorry for taking so long to getting around to this PR.

@JeffreyWay You're a busy dude, don't sweat it. This is an awesome addition though, going to upgrade immediately. So excited!

@pqt
Copy link

pqt commented Nov 6, 2017

Already got it working on my side project just so I could test it out.

@NoelDeMartin you're my hero of the week. Happy Monday to you good sir.

@NoelDeMartin
Copy link
Contributor Author

Glad to help :D Thanks Jeffrey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants