Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated devtool option to a full source-map #1354

Merged
merged 2 commits into from
Jan 15, 2018
Merged

Updated devtool option to a full source-map #1354

merged 2 commits into from
Jan 15, 2018

Commits on Dec 5, 2017

  1. Updated devtool option to a fully source-map

    After reviewing the devtool options from Webpack the `cheap-source-map` option does not make much sense when wanting to have sourcemaps in production.
    
    Sourcemaps in production are usually used for error reporting tools to unminify code within your error reporting tool. Tools like:
    
    - Track.js
    - Sentry
    - Rollbar
    - Etc.
    
    The majority of Webpack plugins that provide support for these error reporting services default to `source-map` as the primary production devtool option. The Webpack documentation also specifies the `eval-source-map` option as follows:
    
    > The following options are not ideal for development nor production.
    
    https://webpack.js.org/configuration/devtool/#special-cases
    
    On the other hand for the `source-map` option it states:
    
    > These options are typically used in production
    
    https://webpack.js.org/configuration/devtool/#production
    
    A full source map provides `original code` quality which is needed for services like these, to work as efficiently as possible.
    
    https://webpack.js.org/configuration/devtool/#devtool
    
    If there are cases against using a full `source-map` for the devtool option in production I would love to hear them.
    stephan-v committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    9f32953 View commit details
    Browse the repository at this point in the history
  2. Update Api.js

    stephan-v committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    75653bd View commit details
    Browse the repository at this point in the history