Fix bug: extractVueStyles not using specified file #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes laravel-mix#1460 Before the fix, we would recycle an existing extract plugin without assigning the custom extraction filename. This is now fixed.
tpraxl
commented
Feb 11, 2018
| @@ -261,28 +261,28 @@ module.exports = function() { | |||
| options: Config.babel() | |||
| }, | |||
|
|
|||
| scss: vueExtractPlugin.extract({ | |||
There was a problem hiding this comment.
I wonder why this didn't crash before, because vueExtractPlugin would have been undefined if Config.extractVueStyles evaluated to false…
|
@JeffreyWay We confirm an issue which this pull request will resolve. Tested locally, looks good. |
|
Thanks! :) |
|
@JeffreyWay When will this PR be in a release? |
|
Next week. |
|
@JeffreyWay ETA on this? Really waiting hard for this fix. |
|
@vyuldashev It's now tagged in v2.1. |
|
@JeffreyWay This breaks unfortunately.
|
|
Yeah, confirmed. Fixing this now, and will tag. |
|
Okay, done. Patched in 2.1.2. |
|
Thanks! It's back to the old situation now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1460
Before the fix, we would recycle an existing extract plugin without assigning the custom extraction filename.
This is now fixed.
Please note that PR #1466 needs to be updated after merging this PR, because it extracted the rules into dedicated files and I doubt that git is smart enough to merge these changes.