Fixes for new tolerance for chunkHashes #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No worries. I'm gonna squash merge the PR anyway :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #3208
In the PR yesterday, the tolerance for chunkHashes was expanded from matching
/\w{20}/, to matching/\w+/. This calls for further adjustment of the version()-function, in case someone would now set the chunkHashes to be even longer, and it needed a slight adjustment of a test case.Sorry for the commit-jumble. I forgot to sync the upstream before pushing to my fork. If this is a problem I can make a new fork and just add 1 commit instead.