Merge pull request #102 from hansnn/fix-failed-event-channel-type

Fix channel type of NotificationFailed events
laravel-notification-channels · Jun 9, 2020 · e99ad69 · e99ad69
2 parents 8be4164 + edb3330
commit e99ad69
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/ApnChannel.php b/src/ApnChannel.php
@@ -96,7 +96,7 @@ protected function dispatchEvents($notifiable, $notification, array $responses)
                 continue;
             }
 
-            $event = new NotificationFailed($notifiable, $notification, $this, [
+            $event = new NotificationFailed($notifiable, $notification, static::class, [
                 'id' => $response->getApnsId(),
                 'token' => $response->getDeviceToken(),
                 'error' => $response->getErrorReason(),

diff --git a/tests/ApnChannelTest.php b/tests/ApnChannelTest.php
@@ -62,4 +62,23 @@ public function it_dispatches_events_for_failed_notifications()
 
         $this->channel->send(new TestNotifiable, new TestNotification);
     }
+
+    /** @test */
+    public function it_dispatches_failed_notification_events_with_correct_channel()
+    {
+        $this->events->shouldReceive('dispatch')
+            ->withArgs(function (NotificationFailed $notificationFailed) {
+                return $notificationFailed->channel === ApnChannel::class;
+            });
+
+        $this->client->shouldReceive('addNotification');
+        $this->client->shouldReceive('push')
+            ->once()
+            ->andReturn([
+                new Response(200, 'headers', 'body'),
+                new Response(400, 'headers', 'body'),
+            ]);
+
+        $this->channel->send(new TestNotifiable, new TestNotification);
+    }
 }