Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added loc-title and other localisation support #101

Merged
merged 5 commits into from Jun 2, 2020
Merged

Added loc-title and other localisation support #101

merged 5 commits into from Jun 2, 2020

Conversation

devsaider
Copy link
Contributor

Localisation support

dwightwatson
dwightwatson requested changes Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@dwightwatson dwightwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a couple of things.

  • Could you please fix the StyleCI errors
  • Could you please add tests for the new methods - should be pretty relatively easy to copy existing ApnMessage tests

With that I'll be able to merge in and tag a new release.

src/ApnMessage.php Outdated
/**
* Variable string values to appear in place of the format specifiers in title-loc-key.
*
* @var string[]|null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do @var string|null - I don't think we've used the array syntax in this project.

src/ApnMessage.php Outdated
/**
* A key to an alert-message string in a Localizable.strings file for the current localization.
*
* @var string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add |null here.

src/ApnMessage.php Outdated
/**
* Variable string values to appear in place of the format specifiers in loc-key.
*
* @var array
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add |null here also.

@dwightwatson
Copy link
Collaborator

Awesome, thanks so much!

@dwightwatson dwightwatson merged commit 8be4164 into laravel-notification-channels:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwightwatson dwightwatson Awaiting requested review from dwightwatson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devsaider @dwightwatson