Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VoIP support with additional channel #91

Merged
merged 8 commits into from
Mar 22, 2020
Merged

Conversation

dwightwatson
Copy link
Collaborator

This extends #90 - I thought I was pushing straight onto that PR but seems I did something wrong. This PR still includes @chimit's work.

  • I added a separate ApnVoipMessage that just sets the push type out of the box. It extends ApnMessage so you can use it just the same, with less boilerplate.
  • I split the tests so the two channels are tested independently. This also meant breaking out some stubs so they could be re-used.
  • I did look to reduce some duplication between the channels but that can always happen later. The send method isn't that long and it's very clear what's going on.

@dwightwatson dwightwatson merged commit 190aa35 into master Mar 22, 2020
@dwightwatson dwightwatson deleted the chimit-master branch March 22, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants