Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in CONTRIBUTING.md #20

Merged
merged 1 commit into from Oct 6, 2018
Merged

Fix typos in CONTRIBUTING.md #20

merged 1 commit into from Oct 6, 2018

Conversation

Rowayda-Khayri
Copy link
Contributor

This PR is to fix typos in CONTRIBUTING.md

@Omranic
Copy link
Collaborator

Omranic commented Oct 6, 2018

Hmmmm, are you sure? 🤔

@Rowayda-Khayri
Copy link
Contributor Author

Rowayda-Khayri commented Oct 6, 2018 •
edited

"New additions" are plural. So, the verbs "bump" and "reset" shouldn't take "s".
The same with "fixes" and "changes" as they are plural.

@Omranic Omranic merged commit 7f3264c into laravel-notification-channels:develop Oct 6, 2018
@Rowayda-Khayri Rowayda-Khayri deleted the fix-typos branch October 6, 2018 15:42
Omranic added a commit that referenced this pull request Mar 3, 2019
@Omranic
Merge branch 'release/v5.0.0'
1fdf3fb 
* release/v5.0.0:
  Bump version
  Require PHP 7.2 & Laravel 5.8
  Update Slack link
  Rename environment variable QUEUE_DRIVER to QUEUE_CONNECTION
  fix typos in CONTRIBUTING.md (#20)
  fix typos (#19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rowayda-Khayri @Omranic