Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 6.0 Support #28

Merged
merged 3 commits into from
Sep 15, 2019
Merged

Laravel 6.0 Support #28

merged 3 commits into from
Sep 15, 2019

Conversation

kawax
Copy link
Contributor

@kawax kawax commented Aug 21, 2019 •
edited
Loading

  • Support only Laravel 6.0
  • Require PHP 7.2

Bump major version.

@wast wast mentioned this pull request Aug 26, 2019
Closed
@atymic
Copy link
Member

atymic commented Sep 10, 2019

I think not having a version constraint is a bad idea. Notifications could change between versions.

Could you update PR to allow versions 5.5 - 6.0?

Thanks!

@kawax kawax changed the title Delete version constraint for Laravel >= 6 Laravel 6.0 Support Sep 15, 2019
@kawax
Copy link
Contributor Author

kawax commented Sep 15, 2019

Please check

@atymic atymic merged commit 742293e into laravel-notification-channels:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kawax @atymic