Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer dependency versions for Laravel 8 #40

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

corsair
Copy link
Contributor

@corsair corsair commented Sep 14, 2020

As noted in the Upgrade Guide for Laravel 8, I've adjusted the composer.json file to allow support for the following:

  • "phpunit/phpunit": "^8.5 || ^9.0" (^9.0 added)
  • "guzzlehttp/guzzle": "^6.3 || ^7.0.1" (^7.0.1 added)

Without this present, the installation of this library will fail for Laravel 8.0 or newer versions.

Error:

    - Root composer.json requires laravel-notification-channels/discord dev-master -> satisfiable by laravel-notification-channels/discord[dev-master].
    - laravel-notification-channels/discord dev-master requires guzzlehttp/guzzle ^6.3 -> found guzzlehttp/guzzle[6.3.0, ..., 6.5.x-dev] but it conflicts with your root composer.json require (^7.0.1).```

As noted in the [Upgrade Guide](https://laravel.com/docs/8.x/upgrade) for Laravel 8, I've adjusted the composer.json file to allow support for the following:
* "phpunit/phpunit": "^8.5 || ^9.0" (^9.0 added)
* "guzzlehttp/guzzle": "^6.3 || ^7.0.1" (^7.0.1 added)

Without this present, the installation of this library will fail for Laravel 8.0 or newer versions.
@@ -30,7 +30,7 @@
"require-dev": {
"mockery/mockery": "^1.3",
"orchestra/testbench": "^5.0 || ^6.0",
"phpunit/phpunit": "^8.5"
"phpunit/phpunit": "^8.5 || ^9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't actually installed in end users apps, but good to allow it in dev anyway :)

@atymic atymic merged commit 457f890 into laravel-notification-channels:master Sep 14, 2020
@corsair corsair deleted the patch-1 branch September 15, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants