Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename configuration options #34

Merged
merged 2 commits into from Oct 4, 2019
Merged

Rename configuration options #34

merged 2 commits into from Oct 4, 2019

Conversation

dwightwatson
Copy link
Collaborator

We currently use app_id and app_secret as configuration option names, which does make sense as they are the names Facebook uses, but I wonder if perhaps we'd be best to match the naming scheme of the Socialite channels.

Here's how it would look right now if you used Socialite and this package together, which I think just looks a little odd and inconsistent.

    'facebook' => [
        'client_id' => env('FACEBOOK_KEY'),
        'client_secret' => env('FACEBOOK_SECRET'),
        'redirect' => '/verifications/facebook/callback',
    ],

    'facebook_poster' => [
        'app_id' => env('FACEBOOK_KEY'),
        'app_secret' => env('FACEBOOK_SECRET'),
        'access_token' => env('FACEBOOK_ACCESS_TOKEN'),
    ],

@dwightwatson dwightwatson merged commit 9fd22ae into master Oct 4, 2019
@dwightwatson dwightwatson deleted the socialite branch October 4, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant