Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 8 support #43

Merged
merged 1 commit into from Sep 10, 2020
Merged

Laravel 8 support #43

merged 1 commit into from Sep 10, 2020

Conversation

Cannonb4ll
Copy link
Contributor

@Cannonb4ll Cannonb4ll commented Sep 9, 2020 •
edited by atymic

Closes #42

@Cannonb4ll Cannonb4ll mentioned this pull request Sep 9, 2020
Closed
@casperboone
Copy link
Member

Hi @Cannonb4ll, thx for the PR! Did you test the package in a Laravel 8 app?

atymic
atymic reviewed Sep 9, 2020
View reviewed changes
composer.json
@@ -14,8 +14,8 @@
"require": {
"php": ">=7.2",
"guzzlehttp/guzzle": "^6.2",
"illuminate/notifications": "~5.5 || ^6.0 || ^7.0",
"illuminate/support": "~5.5 || ^6.0 || ^7.0"
"illuminate/notifications": "~5.5 || ^6.0 || ^7.0 || ^8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth dropping 5.x since it's fully out of support now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @casperboone decide on that, if he agree's I can remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop that once we do a somewhat larger general refresh of the package :)

@Cannonb4ll
Copy link
Contributor Author

@casperboone Yes, worked on a L8.0.2 app!

@casperboone
Copy link
Member

Thx! 😄

@casperboone casperboone merged commit c53bf65 into laravel-notification-channels:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperboone casperboone casperboone left review comments

@atymic atymic atymic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Laravel 8 Support
3 participants
@Cannonb4ll @casperboone @atymic