💥 Improve exceptions

src/Exceptions/PushwooshException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace NotificationChannels\Pushwoosh\Exceptions;
+
+use RuntimeException;
+
+/**
+ * Exception thrown following communication failure with the Pushwoosh API.
+ */
+class PushwooshException extends RuntimeException
+{
+    //
+}

src/Exceptions/UnknownDeviceException.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace NotificationChannels\Pushwoosh\Exceptions;
+
+use Illuminate\Support\Arr;
+use Throwable;
+
+class UnknownDeviceException extends PushwooshException
+{
+    protected $devices;
+
+    /**
+     * Create a new unknown device exception.
+     *
+     * @param mixed $devices
+     * @param int $code
+     * @param \Throwable|null $previous
+     * @return void
+     */
+    public function __construct($devices, $code = 0, Throwable $previous = null)
+    {
+        $this->devices = (array)$devices;
+
+        parent::__construct(
+            sprintf('Unknown device(s) referenced: %s', implode(', ', Arr::flatten($this->devices))),
+            $code,
+            $previous
+        );
+    }
+
+    /**
+     * Get the unknown devices per message.
+     *
+     * @return string[][]
+     */
+    public function getDevices()
+    {
+        return $this->devices;
+    }
+}

src/Pushwoosh.php

@@ -5,6 +5,8 @@
 use GuzzleHttp\ClientInterface;
 use GuzzleHttp\Exception\GuzzleException;
 use GuzzleHttp\Psr7\Request;
+use NotificationChannels\Pushwoosh\Exceptions\PushwooshException;
+use NotificationChannels\Pushwoosh\Exceptions\UnknownDeviceException;
 
 class Pushwoosh
 {
@@ -42,17 +44,17 @@ public function createMessage(PushwooshPendingMessage $message)
         try {
             $response = $this->client->send($request);
         } catch (GuzzleException $exception) {
-            throw PushwooshException::failedTransmission($exception);
+            throw new PushwooshException('Failed to create message(s)', 0, $exception);
         }
 
         $response = \GuzzleHttp\json_decode($response->getBody()->getContents());
 
         if (isset($response->status_code) && $response->status_code !== 200) {
-            throw PushwooshException::apiError($response);
+            throw new PushwooshException($response->status_message);
         }
 
         if (isset($response->response->UnknownDevices)) {
-            throw PushwooshException::unknownDevices($response);
+            throw new UnknownDeviceException($response->response->UnknownDevices);
         }
 
         $message->wasSent();

tests/Unit/PushwooshTest.php

@@ -6,8 +6,9 @@
 use GuzzleHttp\Psr7\Response;
 use Illuminate\Support\Str;
 use Mockery;
+use NotificationChannels\Pushwoosh\Exceptions\PushwooshException;
+use NotificationChannels\Pushwoosh\Exceptions\UnknownDeviceException;
 use NotificationChannels\Pushwoosh\Pushwoosh;
-use NotificationChannels\Pushwoosh\PushwooshException;
 use NotificationChannels\Pushwoosh\PushwooshPendingMessage;
 use PHPUnit\Framework\TestCase;
 
@@ -44,7 +45,7 @@ public function testApiError()
         );
 
         $this->expectException(PushwooshException::class);
-        $this->expectExceptionMessage('Pushwoosh API error: Access denied or application not found');
+        $this->expectExceptionMessage('Access denied or application not found');
 
         $this->pushwoosh->createMessage(
             new PushwooshPendingMessage($this->pushwoosh)
@@ -80,8 +81,8 @@ public function testUnknownDevices()
             new Response(200, [], file_get_contents(__DIR__ . '/../Fixtures/unknown-devices.json'))
         );
 
-        $this->expectException(PushwooshException::class);
-        $this->expectExceptionMessage('Unknown device(s) mentioned: foo, bar');
+        $this->expectException(UnknownDeviceException::class);
+        $this->expectExceptionMessage('Unknown device(s) referenced: foo, bar');
 
         $this->pushwoosh->createMessage(
             new PushwooshPendingMessage($this->pushwoosh)