Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 11 and more #7

Merged
merged 5 commits into from Apr 2, 2024

Conversation

matthiez
Copy link
Contributor

@matthiez matthiez commented Apr 2, 2024

Hi, this pull request should close #6.

It also makes use of some PHP 8 features.

@mxschll
Copy link
Collaborator

mxschll commented Apr 2, 2024

Thanks for the pull request @matthiez! Could you take a look at the error Root composer.json requires php ^8.2 but your php version (8.1.2) does not satisfy that requirement? The changes lgtm.

@matthiez
Copy link
Contributor Author

matthiez commented Apr 2, 2024

Thanks for the pull request @matthiez! Could you take a look at the error Root composer.json requires php ^8.2 but your php version (8.1.2) does not satisfy that requirement? The changes lgtm.

Thanks,

I just specified the PHP version in the workflow. I believe this should do the trick.

@mxschll
Copy link
Collaborator

mxschll commented Apr 2, 2024

Thanks! I believe the GitHub action is still using its default installed PHP version (8.1.2) and is not using the versions specified. I'll merge and adapt the workflow accordingly :)

@mxschll mxschll closed this Apr 2, 2024
@mxschll mxschll reopened this Apr 2, 2024
@mxschll mxschll merged commit 596f197 into laravel-notification-channels:master Apr 2, 2024
0 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Laravel 11 Support
2 participants