Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9.x Compatibility #47

Merged

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/webhook.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "laravel-notification-channels/webhook": "dev-l9-compatibility",
    }
}

Finally, run: composer update

@ipkpjersi
Copy link

ipkpjersi commented Feb 10, 2022

Can someone please accept this PR? It would be very nice to have L9 support.

edit: The failing workflow looks like it's just an intermittent timeout issue, if you run the workflow again I bet it will pass, so I think it'd be okay to accept this PR it should be fine.

@atymic atymic merged commit d3417c5 into laravel-notification-channels:master Feb 15, 2022
mkohei pushed a commit to mkohei/webhook that referenced this pull request Mar 7, 2022
Co-authored-by: atymic <atymicq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants