Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Vs Mail #20

Closed
ManojKiranA opened this issue Nov 19, 2019 · 3 comments · Fixed by #235
Closed

Notification Vs Mail #20

ManojKiranA opened this issue Nov 19, 2019 · 3 comments · Fixed by #235
Labels
enhancement New feature or request good first issue Good for newcomers in progress This issue is being worked on.

Comments

@ManojKiranA
Copy link

I see a stament

send: ReviewNotification to post.author

Which means that it need to Create a Notification class

send: ReviewMail to post.author

Which means that it need to Create a Mail class

@jasonmccreary
Copy link
Collaborator

Yes. I think a little convention here would nice to distinguish which should be created. I'll add this to the list of tweaks post v1.

@andreich1980
Copy link

Sorry for offtopic but where does it get the .author part?
image
I see that it sends a notification to the post's author but there are no author_id column in the posts model.
What am I missing here?

@jasonmccreary
Copy link
Collaborator

You are right. This example is missing the author field.

At the moment, to provide flexibility, Blueprint does not validate the dot notation, it is simply converted to arrow notation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in progress This issue is being worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants