Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept data-raw #13

Closed
wants to merge 6 commits into from
Closed

Accept data-raw #13

wants to merge 6 commits into from

Conversation

dnkmdg
Copy link
Contributor

@dnkmdg dnkmdg commented Oct 13, 2022

Added support for providing data-raw according to #8.

My reasoning for the proposed solution is that they should never be present simultaneously, and if data-raw isn't present, then go for default behavior with the -d|data-option, giving data-raw a slight precedence over data.

@jasonmccreary
Copy link
Collaborator

Looks like this is branched off the other. So once the other is merged, it's going to be a conflict.

@dnkmdg
Copy link
Contributor Author

dnkmdg commented Oct 13, 2022

Looks like this is branched off the other. So once the other is merged, it's going to be a conflict.

Yeah, I just realized that as well. I'll close this one and will make a new once the other PR is merged downstream. Sorry for the confusion!

@dnkmdg dnkmdg closed this Oct 13, 2022
@jasonmccreary
Copy link
Collaborator

No problem.

For this option, I do agree it should probably only be used once. I just don't see any hard rule for that.

I also wonder if it should use Http::withBody() (ref)

@dnkmdg
Copy link
Contributor Author

dnkmdg commented Oct 13, 2022

Are you considering another solution for Http::withBody()? As far as I can tell there's not really any good alternative?

Since it will override the data property it will automatically be handled the same way as the -d|data flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants