Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Linter Shift #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Laravel Linter Shift #17

wants to merge 1 commit into from

Conversation

laravel-shift
Copy link
Owner

This pull request contains code changes and comments for code detected as incompatible or unrecommended by the Laravel Linter. You should review each comment and commit changes to the shift-laravel-linter branch before merging.

If there were items you feel could have been detected, please send your feedback to shift@laravelshift.com or via Twitter.

@laravel-shift
Copy link
Owner Author

⚠ Your Laravel framework dependency is not set to the latest version in Composer. Unless you have a requirement for using a specific version of Laravel, you should set this to "laravel/framework": "5.4.*".

@laravel-shift
Copy link
Owner Author

ℹ Your Laravel version is less than the latest version (5.4). Use Laravel Shift to not only upgrade your project to the latest version of Laravel, but resolve most of the lint detected here.

@laravel-shift
Copy link
Owner Author

⚠ Your app/Exceptions/Handler.php differs from the Laravel default. You should compare your app/Exceptions/Handler.php and with the latest version and make any updates.

@laravel-shift
Copy link
Owner Author

❌ The following configuration files differ from the 5.4 defaults. If you are modifying configuration values directly, you should consider using an environment variable instead. You should compare your configuration files against the Laravel 5.4 configuration files and make any updates.

  • config/app.php
  • config/broadcasting.php
  • config/cache.php
  • config/database.php
  • config/filesystems.php
  • config/mail.php
  • config/queue.php
  • config/view.php

@laravel-shift
Copy link
Owner Author

❌ In Laravel 5.4, you should define channel named placeholders using {name} style placeholders, instead of the * character as in Laravel 5.3.

Shift found potential uses of Broadcast::channel() in:

  • app/Providers/BroadcastServiceProvider.php

@laravel-shift
Copy link
Owner Author

❌ Your project is missing the webpack.mix.js file. Laravel Elixir changed to Laravel Mix in Laravel 5.4 which uses Webpack, instead of Gulp.

@laravel-shift
Copy link
Owner Author

❌ The following PHP classes are missing a namespace. Laravel 5.4 added the Tests namespace for all classes within tests/.

  • tests/TestCase.php
  • tests/ExampleTest.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant